feat: add express endpoints for lightning invoice #5643
Merged
+386
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericli-bitgo
requested changes
Feb 26, 2025
007harshmahajan
force-pushed
the
express_lightning_apis
branch
from
afd8341 to
efca9ce
Compare
ericli-bitgo
requested changes
Feb 26, 2025
007harshmahajan
force-pushed
the
express_lightning_apis
branch
from
efca9ce to
27c866f
Compare
margueriteblair
previously approved these changes
Feb 26, 2025
007harshmahajan
force-pushed
the
express_lightning_apis
branch
from
27c866f to
f906a5d
Compare
lcovar
requested changes
Feb 27, 2025
007harshmahajan
force-pushed
the
express_lightning_apis
branch
from
f906a5d to
8d99a14
Compare
| import * as t from 'io-ts'; | ||
|
|
||
| const UpdateWalletRequest = t.intersection([ | ||
| UpdateLightningWalletSignedRequest, |
There was a problem hiding this comment.
This should contain signerTlsKey instead of encryptedSignerTlsKey.
handleUpdateLightningWalletCoinSpecific should encrypt signerTlsKey to encryptedSignerTlsKey using wallet passphrase (similar to signerAdminMacaroon -> encryptedSignerAdminMacaroon)
lcovar
force-pushed
the
express_lightning_apis
branch
3 times, most recently
from
8832a80 to
220d79e
Compare
davidkaplanbitgo
requested changes
Feb 28, 2025
|
|
||
| if (params.signerTlsKey) { | ||
| requestWithEncryption.encryptedSignerTlsKey = this.wallet.bitgo.encrypt({ | ||
| password: deriveLightningServiceSharedSecret(coinName, userAuthXprv).toString('hex'), |
There was a problem hiding this comment.
Suggested change
| password: deriveLightningServiceSharedSecret(coinName, userAuthXprv).toString('hex'), | |
| password: params.passphrase, |
|
|
||
| if (params.signerMacaroon) { | ||
| requestWithEncryption.encryptedSignerMacaroon = this.wallet.bitgo.encrypt({ | ||
| password: params.passphrase, |
There was a problem hiding this comment.
Suggested change
| password: params.passphrase, | |
| password: deriveLightningServiceSharedSecret(coinName, userAuthXprv).toString('hex'), |
davidkaplanbitgo
previously approved these changes
Feb 28, 2025
margueriteblair
previously approved these changes
Feb 28, 2025
lcovar
previously approved these changes
Feb 28, 2025
lcovar
dismissed stale reviews from margueriteblair, davidkaplanbitgo, and themself
via
a31979f
lcovar
force-pushed
the
express_lightning_apis
branch
from
220d79e to
a31979f
Compare
ericli-bitgo
previously approved these changes
Feb 28, 2025
davidkaplanbitgo
previously approved these changes
Feb 28, 2025
Add - list invoices - update wallet coin specific Ticket: BTC-1836
lcovar
dismissed stale reviews from davidkaplanbitgo and ericli-bitgo
via
01d89de
lcovar
force-pushed
the
express_lightning_apis
branch
from
a31979f to
01d89de
Compare
davidkaplanbitgo
approved these changes
Feb 28, 2025
margueriteblair
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding express apis
Ticket: BTC-1836